www/ajax/discoverCameras.php: set NODE_PATH for js tool cmd #665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In bluecherry-node-onvif package, we bundle the dependencies necessary to avoid relying on packaging of all of them the Debian way. The command "node .../discovery_json/node-onvif.js" doesn't work as it doesn't look for node_modules where we put them, /usr/share/nodejs/onvif/node_modules . This change passes NODE_PATH env var to `node` interpreter command, which is handled as expected by PHP's popen().
curtishall
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In bluecherry-node-onvif package, we bundle the dependencies necessary to avoid relying on packaging of all of them the Debian way.
The command "node .../discovery_json/node-onvif.js" doesn't work as it doesn't look for node_modules where we put them,
/usr/share/nodejs/onvif/node_modules .
This change passes NODE_PATH env var to
nodeinterpreter command, which is handled as expected by PHP's popen().